[MINOR] Remove unused build script that used non-HTTPS to download code#1625
Merged
tuhaihe merged 2 commits intoapache:mainfrom Mar 18, 2026
Merged
[MINOR] Remove unused build script that used non-HTTPS to download code#1625tuhaihe merged 2 commits intoapache:mainfrom
tuhaihe merged 2 commits intoapache:mainfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi, @pjfanning welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!
leborchuk
approved these changes
Mar 17, 2026
Contributor
leborchuk
left a comment
leborchuk
left a comment
There was a problem hiding this comment.
LGTM
I also checked - there are no other files with "archive.apache.org" address without https
reshke
approved these changes
Mar 17, 2026
avamingli
reviewed
Mar 18, 2026
pjfanning
changed the title
Member
|
Hi @pjfanning thanks for your work. We can merge this PR first, then create a new PR to update further. I can do it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It is always a good idea to avoid non TLS endpoints in builds. There might be more instances like this in your repos and I would suggest that a PMC member has a look.
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions